feat: unshare link #307
feat: unshare link #307
Conversation
Summary of ChangesHello @shijinpjlab, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the configuration of a Gradio application. It includes minor adjustments to component property names, specifically changing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces beneficial changes to the Gradio application. It correctly updates the gr.Dataframe components by replacing the deprecated col_count parameter with column_count. More importantly, it enhances security by disabling the public sharing link (share=False), which is a crucial improvement to prevent unintended exposure. I've added one suggestion to make this sharing behavior configurable via an environment variable, which would improve the application's flexibility for different deployment scenarios.
|
|
||
| # Launch interface | ||
| demo.launch(share=True) | ||
| demo.launch(share=False) |
There was a problem hiding this comment.
While disabling sharing by default is a great security improvement, hardcoding share=False reduces flexibility. If there's a future need to enable sharing for a specific use case (e.g., a temporary demo for a remote colleague), it would require a code change. It's better practice to control this via an environment variable. This allows enabling sharing without modifying the code, by simply setting an environment variable before running the script.
| demo.launch(share=False) | |
| demo.launch(share=os.getenv("GRADIO_SHARE") == "True") |
1 participant
No description provided.